8000
Remove unnecessary cmake quotes #1625
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsimantov
approved these changes
Jul 11, 2024
Integration test with FLAKINESS (succeeded after retry)Requested by @jonsimantov on commit ff3561e
Add flaky tests to go/fpl-cpp-flake-tracker |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The GHA machines updated cmake versions, which seems to have a problem when passing in the CMAKE_OSX_ARCHITECTURES with quotes, so remove them. Note that normally when we do the call from scripts, we don't have the quotes, this is just in the part where we have cmake trigger itself for downloads.
Testing
https://github.com/firebase/firebase-unity-sdk/actions/runs/9882221217
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.