8000 Add the new method to update Auth Users Email by a-maurice · Pull Request #1544 · firebase/firebase-cpp-sdk · GitHub
[go: up one dir, main page]
Skip to content

Add the new method to update Auth Users Email #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 29, 2024
Merged

Add the new method to update Auth Users Email #1544

merged 2 commits into from
Feb 29, 2024

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Add User::SendEmailVerificationBeforeUpdatingEmail, which is the new method to update user emails, and deprecate
User::UpdateEmail, which no longer works when Email Enumeration Protection is turned on.

Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Feb 29, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 29, 2024
@github-actions GitHub Actions
Copy link
github-actions bot commented Feb 29, 2024 •
edited
Loading

❌  Integration test FAILED

Requested by @a-maurice on commit 6c1ac8c
Last updated: Thu Feb 29 16:35 PST 2024
View integration test log & download artifacts

Failures Configs
gma [TEST] [FAILURE] [iOS] [macos] [1/2 ios_device: simulator_target]
(4 failed tests)  FirebaseGmaTest.TestAdViewErrorBadAdUnitId
  FirebaseGmaTest.TestInterstitialAdErrorBadAdUnitId
  FirebaseGmaTest.TestNativeAdErrorBadAdUnitId
  FirebaseGmaTest.TestRewardedAdErrorBadAdUnitId

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 29, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 29, 2024
@a-maurice a-maurice added tests-requested: quick Trigger a quick set of integration tests. and removed tests: failed This PR's integration tests failed. labels Feb 29, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: succeeded This PR's integration tests succeeded. and removed tests-requested: quick Trigger a quick set of integration tests. labels Feb 29, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 29, 2024
@a-maurice a-maurice merged commit 6c1ac8c into main Feb 29, 2024
@a-maurice a-maurice deleted the am-update_email branch February 29, 2024 22:10
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Feb 29, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Mar 1, 2024
@firebase firebase locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonsimantov jonsimantov jonsimantov approved these changes

Assignees
No one assigned
Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a-maurice @jonsimantov
0