8000 Replace Collection.emptyMap() with new HashMap() by milaGGL · Pull Request #5573 · firebase/firebase-android-sdk · GitHub
[go: up one dir, main page]
Skip to content

Replace Collection.emptyMap() with new HashMap() #5573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2023
Merged

Replace Collection.emptyMap() with new HashMap() #5573

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ef64122
Update LocalDocumentsView.java
milaGGL Nov 23, 2023
adedf8f
Update CHANGELOG.md
milaGGL Nov 24, 2023
3539251
Merge branch 'master' into mila/fix-mutation-on-emptyMap
milaGGL Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions firebase-firestore/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
# Unreleased
* [fixed] Fixed an issue caused by calling mutation on immutable map object. [#5573](//github.com/firebase/firebase-android-sdk/pull/5573)

* [fixed] Fixed an issue in the local cache synchronization logic where all locally-cached documents that matched a resumed query would be unnecessarily re-downloaded; with the fix it now only downloads the documents that are known to be out-of-sync. [#5506](//github.com/firebase/firebase-android-sdk/pull/5506)
* [fixed] Fixed an issue where GC runs into a infinite loop in a certain case. [#5417](https://github.com/firebase/firebase-android-sdk/issues/5417)

Expand Down
2 changes: 1 addition & 1 deletion firebase-firestore/src/main/java/com/google/firebase/firestore/local/LocalDocumentsView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ LocalDocumentsResult getNextDocuments(String collectionGroup, IndexOffset offset
count - docs.size() > 0
? documentOverlayCache.getOverlays(
collectionGroup, offset.getLargestBatchId(), count - docs.size())
: Collections.emptyMap();
: new HashMap<>();

int largestBatchId = FieldIndex.INITIAL_LARGEST_BATCH_ID;
for (Overlay overlay : overlays.values()) {
Expand Down
0