8000 update firestore version by VinayGuthal · Pull Request #4936 · firebase/firebase-android-sdk · GitHub
[go: up one dir, main page]

Skip to content

Conversation

VinayGuthal
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor
github-actions bot commented Apr 26, 2023

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@google-oss-bot
Copy link
Contributor
1 Warning
⚠️ Did you forget to add a changelog entry? (Add the 'no-changelog' label to the PR to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 26, 2023

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from ? (c2a50cf) to 44.23% (eeabac2) by ?.

    324 individual files with coverage change

    FilenameBase (c2a50cf)Merge (eeabac2)Diff
    AbstractStream.java?34.81%?
    ActivityScope.java?0.00%?
    AggregateField.java?31.03%?
    AggregateQuery.java?22.73%?
    AggregateQuerySnapshot.java?59.52%?
    AggregateSource.java?0.00%?
    AggregationResult.java?0.00%?
    AggregationResultOrBuilder.java?0.00%?
    AggregationResultProto.java?0.00%?
    AndroidConnectivityMonitor.java?39.51%?
    ApiUtil.java?12.50%?
    ArrayContainsAnyFilter.java?100.00%?
    ArrayContainsFilter.java?100.00%?
    ArrayTransformOperation.java?86.49%?
    ArrayValue.java?48.60%?
    ArrayValueOrBuilder.java?0.00%?
    Assert.java?60.00%?
    AsyncEventListener.java?0.00%?
    AsyncQueue.java?70.65%?
    AutoValue_FieldIndex.java?58.33%?
    AutoValue_FieldIndex_IndexOffset.java?58.62%?
    AutoValue_FieldIndex_IndexState.java?59.09%?
    AutoValue_FieldIndex_Segment.java?54.17%?
    AutoValue_IndexEntry.java?34.21%?
    AutoValue_Overlay.java?54.55%?
    AutoValue_TestingHooks_ExistenceFilterMismatchInfo.java?20.00%?
    BackgroundQueue.java?81.25%?
    BasePath.java?86.54%?
    BatchGetDocumentsRequest.java?0.00%?
    BatchGetDocumentsRequestOrBuilder.java?0.00%?
    BatchGetDocumentsResponse.java?0.00%?
    BatchGetDocumentsResponseOrBuilder.java?0.00%?
    BeginTransactionRequest.java?0.00%?
    BeginTransactionRequestOrBuilder.java?0.00%?
    BeginTransactionResponse.java?0.00%?
    BeginTransactionResponseOrBuilder.java?0.00%?
    Blob.java?76.92%?
    Bound.java?39.29%?
    BundleCache.java?0.00%?
    BundleCallback.java?0.00%?
    BundledDocumentMetadata.java?0.00%?
    BundledDocumentMetadataOrBuilder.java?0.00%?
    BundleDocument.java?90.00%?
    BundledQuery.java?34.57%?
    BundledQueryOrBuilder.java?0.00%?
    BundleElement.java?0.00%?
    BundleElementOrBuilder.java?0.00%?
    BundleLoader.java?100.00%?
    BundleMetadata.java?0.00%?
    BundleMetadataOrBuilder.java?0.00%?
    BundleProto.java?0.00%?
    BundleReader.java?95.29%?
    BundleSerializer.java?89.52%?
    ByteBufferInputStream.java?83.33%?
    CollectionReference.java?13.64%?
    CommitRequest.java?0.00%?
    CommitRequestOrBuilder.java?0.00%?
    CommitResponse.java?0.00%?
    CommitResponseOrBuilder.java?0.00%?
    CommonProto.java?0.00%?
    ComponentProvider.java?100.00%?
    CompositeFilter.java?98.57%?
    ConnectivityMonitor.java?0.00%?
    Consumer.java?0.00%?
    CreateDocumentRequest.java?0.00%?
    CreateDocumentRequestOrBuilder.java?0.00%?
    CredentialsProvider.java?100.00%?
    Cursor.java?35.29%?
    CursorOrBuilder.java?0.00%?
    CustomClassMapper.java?84.25%?
    DatabaseId.java?70.37%?
    DatabaseInfo.java?90.91%?
    Datastore.java?26.47%?
    DatastoreTestTrace.java?0.00%?
    DeleteDocumentRequest.java?0.00%?
    DeleteDocumentRequestOrBuilder.java?0.00%?
    DeleteMutation.java?95.24%?
    DirectionalIndexByteEncoder.java?100.00%?
    Document.java?100.00%?
    DocumentChange.java?67.61%?
    DocumentChangeOrBuilder.java?0.00%?
    DocumentCollections.java?83.33%?
    DocumentDelete.java?34.62%?
    DocumentDeleteOrBuilder.java?0.00%?
    DocumentId.java?0.00%?
    DocumentKey.java?97.14%?
    DocumentMask.java?40.66%?
    DocumentMaskOrBuilder.java?0.00%?
    DocumentOrBuilder.java?0.00%?
    DocumentOverlayCache.java?0.00%?
    DocumentProto.java?0.00%?
    DocumentReference.java?13.24%?
    DocumentRemove.java?29.23%?
    DocumentRemoveOrBuilder.java?0.00%?
    DocumentSet.java?83.78%?
    DocumentSnapshot.java?37.50%?
    DocumentTransform.java?29.31%?
    DocumentTransformOrBuilder.java?0.00%?
    DocumentViewChange.java?90.91%?
    DocumentViewChangeSet.java?87.88%?
    EncodedPath.java?93.22%?
    EventListener.java?0.00%?
    EventManager.java?96.15%?
    Exclude.java?0.00%?
    Executors.java?100.00%?
    ExistenceFilter.java?80.00%?
    ExistenceFilterOrBuilder.java?0.00%?
    ExponentialBackoff.java?30.43%?
    FieldFilter.java?93.06%?
    FieldIndex.java?98.18%?
    FieldMask.java?57.89%?
    FieldPath.java?89.66%?
    FieldTransform.java?64.71%?
    FieldValue.java?82.14%?
    FileUtil.java?0.00%?
    Filter.java?0.00%?
    FirebaseAppCheckTokenProvider.java?93.75%?
    FirebaseAuthCredentialsProvider.java?100.00%?
    FirebaseClientGrpcMetadataProvider.java?44.00%?
    FirebaseFirestore.java?38.33%?
    FirebaseFirestoreException.java?83.72%?
    FirebaseFirestoreSettings.java?71.91%?
    FirestoreCallCredentials.java?18.60%?
    FirestoreChannel.java?18.10%?
    FirestoreClient.java?36.11%?
    FirestoreGrpc.java?2.46%?
    FirestoreIndexValueWriter.java?77.11%?
    FirestoreMultiDbComponent.java?100.00%?
    FirestoreProto.java?0.00%?
    FirestoreRegistrar.java?100.00%?
    Function.java?0.00%?
    GeoPoint.java?91.67%?
    GetDocumentRequest.java?0.00%?
    GetDocumentRequestOrBuilder.java?0.00%?
    GrpcCallProvider.java?69.41%?
    GrpcMetadataProvider.java?0.00%?
    IgnoreExtraProperties.java?0.00%?
    IncomingStreamObserver.java?0.00%?
    Index.java?30.02%?
    IndexBackfiller.java?100.00%?
    IndexByteEncoder.java?88.57%?
    IndexEntry.java?100.00%?
    IndexManager.java?100.00%?
    IndexOrBuilder.java?0.00%?
    IndexProto.java?0.00%?
    InFilter.java?100.00%?
    IntMath.java?41.67%?
    KeyFieldFilter.java?66.67%?
    KeyFieldInFilter.java?0.00%?
    KeyFieldNotInFilter.java?0.00%?
    LimboDocumentChange.java?70.59%?
    ListCollectionIdsRequest.java?0.00%?
    ListCollectionIdsRequestOrBuilder.java?0.00%?
    ListCollectionIdsResponse.java?0.00%?
    ListCollectionIdsResponseOrBuilder.java?0.00%?
    ListDocumentsRequest.java?0.00%?
    ListDocumentsRequestOrBuilder.java?0.00%?
    ListDocumentsResponse.java?0.00%?
    ListDocumentsResponseOrBuilder.java?0.00%?
    Listener.java?0.00%?
    ListenerRegistration.java?0.00%?
    ListenerRegistrationImpl.java?0.00%?
    ListenRequest.java?10.66%?
    ListenRequestOrBuilder.java?0.00%?
    ListenResponse.java?32.64%?
    ListenResponseOrBuilder.java?0.00%?
    ListenSequence.java?100.00%?
    LoadBundleTask.java?25.26%?
    LoadBundleTaskProgress.java?60.47%?
    LocalCacheSettings.java?0.00%?
    LocalDocumentsResult.java?100.00%?
    LocalDocumentsView.java?100.00%?
    LocalSerializer.java?97.35%?
    LocalStore.java?100.00%?
    LocalViewChanges.java?100.00%?
    Logger.java?91.67%?
    LogicUtils.java?96.67%?
    LruDelegate.java?0.00%?
    LruGarbageCollector.java?93.64%?
    MapValue.java?53.00%?
    MapValueOrBuilder.java?0.00%?
    MemoryBundleCache.java?100.00%?
    MemoryCacheSettings.java?50.00%?
    MemoryComponentProvider.java?82.93%?
    MemoryDocumentOverlayCache.java?100.00%?
    MemoryEagerGcSettings.java?28.57%?
    MemoryEagerReferenceDelegate.java?100.00%?
    MemoryGarbageCollectorSettings.java?0.00%?
    MemoryIndexManager.java?68.97%?
    MemoryLruGcSettings.java?0.00%?
    MemoryLruReferenceDelegate.java?96.00%?
    MemoryMutationQueue.java?100.00%?
    MemoryOverlayMigrationManager.java?100.00%?
    MemoryPersistence.java?100.00%?
    MemoryRemoteDocumentCache.java?98.28%?
    MemoryTargetCache.java?100.00%?
    MetadataChanges.java?100.00%?
    MutableDocument.java?100.00%?
    Mutation.java?100.00%?
    MutationBatch.java?89.23%?
    MutationBatchResult.java?100.00%?
    MutationQueue.java?0.00%?
    MutationResult.java?100.00%?
    NamedQuery.java?0.00%?
    NamedQueryOrBuilder.java?0.00%?
    NotInFilter.java?85.71%?
    NumberComparisonHelper.java?100.00%?
    NumericIncrementTransformOperation.java?87.50%?
    ObjectValue.java?99.06%?
    OnlineState.java?100.00%?
    OnlineStateTracker.java?98.11%?
    OnProgressListener.java?0.00%?
    OrderBy.java?96.55%?
    OrderedCodeWriter.java?68.52%?
    Overlay.java?100.00%?
    OverlayedDocument.java?100.00%?
    OverlayMigrationManager.java?0.00%?
    PatchMutation.java?100.00%?
    Persistence.java?100.00%?
    PersistentCacheSettings.java?62.50%?
    Precondition.java?37.82%?
    PreconditionOrBuilder.java?0.00%?
    Preconditions.java?57.89%?
    PropertyName.java?0.00%?
    Query.java?3.96%?
    QueryDocumentSnapshot.java?64.71%?
    QueryEngine.java?98.63%?
    QueryListener.java?100.00%?
    QueryProto.java?0.00%?
    QueryPurpose.java?100.00%?
    QueryResult.java?100.00%?
    QuerySnapshot.java?76.36%?
    QueryView.java?100.00%?
    ReferenceDelegate.java?0.00%?
    ReferenceSet.java?92.45%?
    RemoteDocumentCache.java?0.00%?
    RemoteEvent.java?92.31%?
    RemoteSerializer.java?80.57%?
    RemoteStore.java?88.49%?
    ResourcePath.java?94.74%?
    RollbackRequest.java?0.00%?
    RollbackRequestOrBuilder.java?0.00%?
    RunAggregationQueryRequest.java?0.00%?
    RunAggregationQueryRequestOrBuilder.java?0.00%?
    RunAggregationQueryResponse.java?0.00%?
    RunAggregationQueryResponseOrBuilder.java?0.00%?
    RunQueryRequest.java?0.00%?
    RunQueryRequestOrBuilder.java?0.00%?
    RunQueryResponse.java?0.00%?
    RunQuery F440 ResponseOrBuilder.java?0.00%?
    Scheduler.java?0.00%?
    ServerTimestamp.java?0.00%?
    ServerTimestampOperation.java?100.00%?
    ServerTimestamps.java?96.00%?
    SetMutation.java?94.44%?
    SetOptions.java?0.00%?
    SnapshotMetadata.java?68.75%?
    SnapshotVersion.java?87.50%?
    Source.java?0.00%?
    SQLiteBundleCache.java?90.00%?
    SQLiteComponentProvider.java?100.00%?
    SQLiteDocumentOverlayCache.java?97.85%?
    SQLiteIndexManager.java?99.49%?
    SQLiteLruReferenceDelegate.java?98.67%?
    SQLiteMutationQueue.java?82.76%?
    SQLiteOverlayMigrationManager.java?90.48%?
    SQLitePersistence.java?86.34%?
    SQLiteRemoteDocumentCache.java?98.21%?
    SQLiteSchema.java?96.63%?
    SQLiteTargetCache.java?98.47%?
    Stream.java?100.00%?
    StructuredAggregationQuery.java?0.00%?
    StructuredAggregationQueryOrBuilder.java?0.00%?
    StructuredQuery.java?32.54%?
    StructuredQueryOrBuilder.java?0.00%?
    Supplier.java?0.00%?
    SyncEngine.java?93.31%?
    Target.java?95.79%?
    TargetCache.java?0.00%?
    TargetChange.java?80.00%?
    TargetChangeOrBuilder.java?0.00%?
    TargetData.java?77.50%?
    TargetIdGenerator.java?100.00%?
    TargetIndexMatcher.java?100.00%?
    TargetOrBuilder.java?0.00%?
    TargetState.java?97.78%?
    TestingHooks.java?40.91%?
    ThrottledForwardingExecutor.java?100.00%?
    ThrowOnExtraProperties.java?0.00%?
    Timestamp.java?80.39%?
    Token.java?0.00%?
    Transaction.java?0.00%?
    TransactionOptions.java?0.00%?
    TransactionOptionsOrBuilder.java?0.00%?
    TransactionRunner.java?0.00%?
    TransformOperation.java?0.00%?
    UpdateDocumentRequest.java?0.00%?
    UpdateDocumentRequestOrBuilder.java?0.00%?
    User.java?78.57%?
    UserData.java?66.00%?
    UserDataReader.java?70.48%?
    UserDataWriter.java?51.02%?
    Util.java?67.63%?
    Value.java?41.22%?
    ValueOrBuilder.java?0.00%?
    Values.java?95.65%?
    VerifyMutation.java?46.15%?
    View.java?96.82%?
    ViewChange.java?100.00%?
    ViewSnapshot.java?89.23%?
    WatchChange.java?70.51%?
    WatchChangeAggregator.java?98.26%?
    WatchStream.java?19.23%?
    Write.java?36.11%?
    WriteBatch.java?0.00%?
    WriteOrBuilder.java?0.00%?
    WriteProto.java?0.00%?
    WriteRequest.java?10.41%?
    WriteRequestOrBuilder.java?0.00%?
    WriteResponse.java?11.70%?
    WriteResponseOrBuilder.java?0.00%?
    WriteResult.java?0.00%?
    WriteResultOrBuilder.java?0.00%?
    WriteStream.java?31.82%?

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/y3wfjqsCjK.html

@github-actions
Copy link
Contributor
github-actions bot commented Apr 26, 2023

Unit Test Results

   160 files  ±0     160 suites  ±0   2m 5s ⏱️ ±0s
1 125 tests ±0  1 109 ✔️ ±0  16 💤 ±0  0 ±0 
2 250 runs  ±0  2 218 ✔️ ±0  32 💤 ±0  0 ±0 

Results for commit 6ecc82b. ± Comparison against base commit c2a50cf.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Apr 26, 2023

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (c2a50cf)Merge (eeabac2)Diff
    aar1.33 MB1.33 MB+6 B (+0.0%)
    apk (aggressive)518 kB518 kB+4 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/itrlNFvOVh.html

@VinayGuthal VinayGuthal requested a review from wu-hui April 26, 2023 14:59
@google-oss-bot
Copy link
Contributor

Startup Time Report 1

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

Startup Times

  • fire-fst

    DeviceStatisticsDistributions
    oriole-32
    Percentilec2a50cfeeabac2DiffSignificant (?)
    p10348 ±43 μs345 ±78 μs-3.49 μs (-1.0%)NO
    p25365 ±53 μs359 ±90 μs-6.76 μs (-1.9%)NO
    p50396 ±72 μs381 ±107 μs-15.6 μs (-3.9%)NO
    p75459 ±97 μs449 ±160 μs-9.77 μs (-2.1%)NO
    p90550 ±151 μs536 ±228 μs-14.7 μs (-2.7%)NO

    20 test runs in comparison
    CommitTest Runs
    c2a50cf
    • 2023-04-26_14:52:38.843927_Jqdc
    • 2023-04-26_14:52:38.850372_MzpY
    • 2023-04-26_14:52:38.850394_Iofk
    • 2023-04-26_14:52:38.850402_WXXe
    • 2023-04-26_14:52:38.850408_sGVi
    • 2023-04-26_14:52:38.850415_nacC
    • 2023-04-26_14:52:38.850422_Zylt
    • 2023-04-26_14:52:38.850433_lzeg
    • 2023-04-26_14:52:38.850438_DXqv
    • 2023-04-26_14:52:38.850444_Zolu
    eeabac2
    • 2023-04-26_15:22:37.963453_knte
    • 2023-04-26_15:22:37.968389_INES
    • 2023-04-26_15:22:37.968420_jklk
    • 2023-04-26_15:22:37.968432_YebF
    • 2023-04-26_15:22:37.968444_rLHn
    • 2023-04-26_15:22:37.968456_WCBj
    • 2023-04-26_15:22:37.968467_PPlM
    • 2023-04-26_15:22:37.968478_DVrC
    • 2023-04-26_15:22:37.968488_QWuk
    • 2023-04-26_15:22:37.968499_zMkt
    redfin-30
    Percentilec2a50cfeeabac2DiffSignificant (?)
    p10637 ±23 μs633 ±17 μs-4.01 μs (-0.6%)NO
    p25656 ±27 μs662 ±27 μs+6.82 μs (+1.0%)NO
    p50685 ±38 μs689 ±31 μs+4.59 μs (+0.7%)NO
    p75722 ±51 μs733 ±48 μs+10.7 μs (+1.5%)NO
    p90790 ±102 μs786 ±66 μs-3.97 μs (-0.5%)NO

    20 test runs in comparison
    CommitTest Runs
    c2a50cf
    • 2023-04-26_14:52:38.843927_Jqdc
    • 2023-04-26_14:52:38.850372_MzpY
    • 2023-04-26_14:52:38.850394_Iofk
    • 2023-04-26_14:52:38.850402_WXXe
    • 2023-04-26_14:52:38.850408_sGVi
    • 2023-04-26_14:52:38.850415_nacC
    • 2023-04-26_14:52:38.850422_Zylt
    • 2023-04-26_14:52:38.850433_lzeg
    • 2023-04-26_14:52:38.850438_DXqv
    • 2023-04-26_14:52:38.850444_Zolu
    eeabac2
    • 2023-04-26_15:22:37.963453_knte
    • 2023-04-26_15:22:37.968389_INES
    • 2023-04-26_15:22:37.968420_jklk
    • 2023-04-26_15:22:37.968432_YebF
    • 2023-04-26_15:22:37.968444_rLHn
    • 2023-04-26_15:22:37.968456_WCBj
    • 2023-04-26_15:22:37.968467_PPlM
    • 2023-04-26_15:22:37.968478_DVrC
    • 2023-04-26_15:22:37.968488_QWuk
    • 2023-04-26_15:22:37.968499_zMkt
  • timeToInitialDisplay

    DeviceStatisticsDistributions
    oriole-32
    Percentilec2a50cfeeabac2DiffSignificant (?)
    p10198 ±9 ms204 ±25 ms+6.36 ms (+3.2%)NO
    p25204 ±9.8 ms211 ±27 ms+6.92 ms (+3.4%)NO
    p50212 ±12 ms220 ±30 ms+8.41 ms (+4.0%)NO
    p75228 ±25 ms234 ±42 ms+6.54 ms (+2.9%)NO
    p90240 ±32 ms254 ±58 ms+14.3 ms (+6.0%)NO

    20 test runs in comparison
    CommitTest Runs
    c2a50cf
    • 2023-04-26_14:52:38.843927_Jqdc
    • 2023-04-26_14:52:38.850372_MzpY
    • 2023-04-26_14:52:38.850394_Iofk
    • 2023-04-26_14:52:38.850402_WXXe
    • 2023-04-26_14:52:38.850408_sGVi
    • 2023-04-26_14:52:38.850415_nacC
    • 2023-04-26_14:52:38.850422_Zylt
    • 2023-04-26_14:52:38.850433_lzeg
    • 2023-04-26_14:52:38.850438_DXqv
    • 2023-04-26_14:52:38.850444_Zolu
    eeabac2
    • 2023-04-26_15:22:37.963453_knte
    • 2023-04-26_15:22:37.968389_INES
    • 2023-04-26_15:22:37.968420_jklk
    • 2023-04-26_15:22:37.968432_YebF
    • 2023-04-26_15:22:37.968444_rLHn
    • 2023-04-26_15:22:37.968456_WCBj
    • 2023-04-26_15:22:37.968467_PPlM
    • 2023-04-26_15:22:37.968478_DVrC
    • 2023-04-26_15:22:37.968488_QWuk
    • 2023-04-26_15:22:37.968499_zMkt
    redfin-30
    Percentilec2a50cfeeabac2DiffSignificant (?)
    p10231 ±3 ms256 ±5 ms+24.3 ms (+10.5%)MAYBE
    p25237 ±4 ms261 ±5 ms+24.0 ms (+10.1%)YES
    p50244 ±4 ms269 ±6 ms+24.3 ms (+10.0%)MAYBE
    p75253 ±4 ms278 ±8 ms+25.3 ms (+10.0%)MAYBE
    p90261 ±6 ms290 ±8 ms+29.3 ms (+11.2%)MAYBE

    20 test runs in comparison
    CommitTest Runs
    c2a50cf
    • 2023-04-26_14:52:38.843927_Jqdc
    • 2023-04-26_14:52:38.850372_MzpY
    • 2023-04-26_14:52:38.850394_Iofk
    • 2023-04-26_14:52:38.850402_WXXe
    • 2023-04-26_14:52:38.850408_sGVi
    • 2023-04-26_14:52:38.850415_nacC
    • 2023-04-26_14:52:38.850422_Zylt
    • 2023-04-26_14:52:38.850433_lzeg
    • 2023-04-26_14:52:38.850438_DXqv
    • 2023-04-26_14:52:38.850444_Zolu
    eeabac2
    • 2023-04-26_15:22:37.963453_knte
    • 2023-04-26_15:22:37.968389_INES
    • 2023-04-26_15:22:37.968420_jklk
    • 2023-04-26_15:22:37.968432_YebF
    • 2023-04-26_15:22:37.968444_rLHn
    • 2023-04-26_15:22:37.968456_WCBj
    • 2023-04-26_15:22:37.968467_PPlM
    • 2023-04-26_15:22:37.968478_DVrC
    • 2023-04-26_15:22:37.968488_QWuk
    • 2023-04-26_15:22:37.968499_zMkt

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/FGerZStY0V/index.html

@VinayGuthal VinayGuthal merged commit f47a0dd into master Apr 26, 2023
@VinayGuthal VinayGuthal deleted the udpate_firestore_version branch April 26, 2023 16:56
@firebase firebase locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

0