8000 Fix overlay recalculation bug with multiple batches by wu-hui · Pull Request #3495 · firebase/firebase-android-sdk · GitHub
[go: up one dir, main page]
Skip to content

Fix overlay recalculation bug with multiple batches #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 28, 2022
Merged

Fix overlay recalculation bug with multiple batches #3495

merged 9 commits into from
Feb 28, 2022

Conversation

wu-hui
Copy link
Contributor
@wu-hui wu-hui commented Feb 28, 2022 •
edited
Loading

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Feb 28, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.59% (ca4ca38) to 45.59% (6f60883) by -0.00%.

    FilenameBase (ca4ca38)Merge (6f60883)Diff
    DeleteMutation.java95.00%90.00%-5.00%
    SetMutation.java97.14%94.29%-2.86%

Test Logs

Notes

  • Commit (6f60883) is created by Prow via merging PR base commit (ca4ca38) and head commit (4e87eba).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lxkOQTF5Ro.html

@google-oss-bot
Copy link
Contributor
google-oss-bot commented Feb 28, 2022 •
edited
Loading

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (ca4ca38)Merge (6f60883)Diff
    aar1.24 MB1.24 MB+34 B (+0.0%)
    apk (release)3.38 MB3.38 MB-12 B (-0.0%)

Test Logs

Notes

  • Commit (6f60883) is created by Prow via merging PR base commit (ca4ca38) and head commit (4e87eba).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/WyfM7i882s.html

@wu-hui wu-hui changed the title Write document without base Fix overlay recalculation bug with multiple batches Feb 28, 2022
schmidt-sebastian
schmidt-sebastian reviewed Feb 28, 2022
View reviewed changes
Copy link
Contributor
@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add changelog

@wu-hui wu-hui assigned schmidt-sebastian and unassigned wu-hui Feb 28, 2022
schmidt-sebastian
schmidt-sebastian approved these changes Feb 28, 2022
View reviewed changes
wu-hui and others added 3 commits February 28, 2022 13:48
@wu-hui
Mention NPE
49d374d
@wu-hui @schmidt-sebastian
Update firebase-firestore/src/main/java/com/google/firebase/firestore…
b43d6d0 
…/local/LocalDocumentsView.java

Co-authored-by: Sebastian Schmidt <mrschmidt@google.com>
@wu-hui
Format
4e87eba
@google-oss-bot
Copy link
Contributor

@wu-hui: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests 4e87eba link /test smoke-tests
device-check-changed 4e87eba link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wu-hui wu-hui merged commit 9b2c2d3 into master Feb 28, 2022
@wu-hui wu-hui deleted the wuandy/WriteWithoutBase branch February 28, 2022 21:59
@russellwheatley russellwheatley mentioned this pull request Mar 1, 2022
Closed
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@wu-hui @jeremyjiang-dev
Fix overlay recalculation bug with multiple batches (#3495)
9a6b2ea
@firebase firebase locked and limited conversation to collaborators Mar 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@wu-hui wu-hui

Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal Exception: java.lang.RuntimeException: Internal error in Cloud Firestore (24.0.1)
3 participants
@wu-hui @google-oss-bot @schmidt-sebastian
0