8000 chore: Upgraded Google Auth, Cloud Firestore, and Cloud Storage dependencies by lahirumaramba · Pull Request #544 · firebase/firebase-admin-python · GitHub
[go: up one dir, main page]

Skip to content

chore: Upgraded Google Auth, Cloud Firestore, and Cloud Storage dependencies< 10000 /bdi> #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

lahirumaramba
Copy link
Member
@lahirumaramba lahirumaramba commented Apr 20, 2021
  • Upgraded Auth, Firestore, and Storage versions

RELEASE NOTE: Upgraded google-cloud-firestore dependency version to to 2.1.0.
RELEASE NOTE: Upgraded google-cloud-storage dependency version to 1.37.1.
RELEASE NOTE: Upgraded google-api-core dependency version to 1.22.1.

Note: Staging to trigger integration tests

Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Just one change needed.

requirements.txt Outdated
google-auth == 1.18.0 # temporary workaround
google-cloud-firestore >= 1.4.0; platform.python_implementation != 'PyPy'
google-cloud-storage >= 1.18.0
google-auth == 1.28.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can now drop this altogether, and let it be transitively installed. (temp workaround was to pin it at an old version)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! removed the google-auth dependency

@lahirumaramba lahirumaramba merged commit 44ae038 into master Apr 21, 2021
@lahirumaramba lahirumaramba deleted the lm-upgrade-libs branch April 21, 2021 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0