FCM Options Support in WebpushConfig API #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #202 |
bklimt
approved these changes
Jan 4, 2019
firebase_admin/_messaging_utils.py
Outdated
| """Options for features provided by the FCM SDK for Web. | ||
|
|
||
| Args: | ||
| link: The link to open when the user clicks on the notification. Must be a HTTPS URL |
| } | ||
| result = cls.remove_null_values(result) | ||
| link = result.get('link') | ||
| if link is not None and not link.startswith('https://'): |
There was a problem hiding this comment.
Should we allow alternate capitalization on the protocol? I mean, "HTTPS://" is probably okay, right?
There was a problem hiding this comment.
Yes, but we have always checked only for the lower-cased prefix in this codebase (there are similar URL checks in auth, db etc). So I'll keep this consistent with that. Also developers haven't requested this, so it should be ok.
bklimt
approved these changes
Jan 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the
fcm_optionsparameter to theWebpushConfigtype. Change ported from firebase/firebase-admin-node#373Resolves #203