8000 Handling non-existing validSince case on UserRecord by hiranya911 · Pull Request #220 · firebase/firebase-admin-python · GitHub
[go: up one dir, main page]
Skip to content

Handling non-existing validSince case on UserRecord #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hiranya911 merged 3 commits into from
Nov 16, 2018
Merged

Handling non-existing validSince case on UserRecord #220

hiranya911 merged 3 commits into from
Nov 16, 2018

Conversation

@hiranya911
Copy link
Contributor
@hiranya911 hiranya911 commented Nov 13, 2018

When the validSince parameter is not present on the UserRecord we should return 0. Returning None here can break other APIs. See #199.

@hiranya911 hiranya911 requested a review from bklimt November 16, 2018 18:56
bklimt
bklimt approved these changes Nov 16, 2018
View reviewed changes
Copy link
Collaborator
@bklimt bklimt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned hiranya911 and unassigned bklimt Nov 16, 2018
@hiranya911 hiranya911 merged commit cd38b6f into master Nov 16, 2018
@hiranya911 hiranya911 deleted the hkj-valid-since branch November 16, 2018 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bklimt bklimt bklimt approved these changes

Assignees

@hiranya911 hiranya911

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hiranya911 @bklimt
0