10000 Basic firebaseopensource config by samtstern · Pull Request #192 · firebase/firebase-admin-python · GitHub
[go: up one dir, main page]
Skip to content

Basic firebaseopensource config #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 15, 2018
Merged

Basic firebaseopensource config #192

merged 2 commits into from
Aug 15, 2018

Conversation

samtstern
Copy link
Contributor

No description provided.

@samtstern samtstern requested a review from hiranya911 August 15, 2018 16:16
hiranya911
hiranya911 approved these changes Aug 15, 2018
View reviewed changes
Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.opensource/project.json
"firebase/firebase-admin-node",
"firebase/firebase-admin-go"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Add newline at eof

@samtstern samtstern merged commit 73616a7 into firebase:master Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@samtstern samtstern

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samtstern @hiranya911
0