8000 Bumped version to 2.9.1 by avishalom · Pull Request #137 · firebase/firebase-admin-python · GitHub
[go: up one dir, main page]
Skip to content

Bumped version to 2.9.1 #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2018
Merged

Bumped version to 2.9.1 #137

merged 4 commits into from
Mar 15, 2018

Conversation

avishalom
Copy link
Contributor

Also updated changelog

@avishalom avishalom requested a review from hiranya911 March 15, 2018 18:06
hiranya911
hiranya911 approved these changes Mar 15, 2018
View reviewed changes
Copy link
Contributor
@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one change suggested.

CHANGELOG.md Outdated
- [changed] Improved error handling in FCM by mapping more server-side
errors to client-side error codes.
errors to client-side error codes. See [documentation](/docs/cloud-messaging/admin/errors).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute URL here.

@avishalom avishalom assigned hiranya911 and unassigned avishalom Mar 15, 2018
@avishalom avishalom merged commit 7e0d47e into master Mar 15, 2018
@avishalom avishalom deleted the vish-release-2_9_1 branch March 19, 2018 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiranya911 hiranya911 hiranya911 approved these changes

Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avishalom @hiranya911
0