8000 fix FcmErrorCode error type by chemidy · Pull Request #391 · firebase/firebase-admin-node · GitHub
[go: up one dir, main page]
Skip to content

fix FcmErrorCode error type #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 15, 2018
Merged

fix FcmErrorCode error type #391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753f7ce
fix FcmErrorCode error type
chemidy Nov 15, 2018
a043f0c
add changelog
chemidy Nov 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# Unreleased

-
- [fixed] Fixing error handling in FCM. The SDK now checks the key
type.googleapis.com/google.firebase.fcm.v1.FcmError to set error code.

# v6.1.0

Expand Down
2 changes: 1 addition & 1 deletion src/messaging/messaging-api-request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ export class FirebaseMessagingRequestHandler {
return response.error;
}
if (validator.isArray(response.error.details)) {
const fcmErrorType = 'type.googleapis.com/google.firebase.fcm.v1.FcmErrorCode';
const fcmErrorType = 'type.googleapis.com/google.firebase.fcm.v1.FcmError';
for (const element of response.error.details) {
if (element['@type'] === fcmErrorType) {
return element.errorCode;
Expand Down
2 changes: 1 addition & 1 deletion test/unit/messaging/messaging.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ describe('Messaging', () => {
message: 'test error message',
details: [
{
'@type': 'type.googleapis.com/google.firebase.fcm.v1.FcmErrorCode',
'@type': 'type.googleapis.com/google.firebase.fcm.v1.FcmError',
'errorCode': 'UNREGISTERED',
},
],
Expand Down
0