10000 Fixed docgen for `getDownloadURL` by maneesht · Pull Request #2241 · firebase/firebase-admin-node · GitHub
[go: up one dir, main page]
Skip to content

Fixed docgen for getDownloadURL #2241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 11, 2023
Merged

Fixed docgen for getDownloadURL #2241

merged 4 commits into from
Jul 11, 2023

Conversation

maneesht
Copy link
Contributor
  • Fixed link to getDownloadURL argument reference, file
  • /s/getDownloadUrl/getDownloadURL

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Jul 10, 2023
lahirumaramba
lahirumaramba approved these changes Jul 11, 2023
View reviewed changes
Copy link
Member
@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, Maneesh! LGTM!

@lahirumaramba lahirumaramba merged commit aa1bb15 into master Jul 11, 2023
@lahirumaramba lahirumaramba deleted the mtewani/fix-doc-gen branch July 11, 2023 14:49
@roblo1801 roblo1801 mentioned this pull request May 17, 2024
Open
@X-oss-byte X-oss-byte mentioned this pull request Jun 11, 2024
Open
@aravindvnair99 aravindvnair99 mentioned this pull request Jun 24, 2024
Closed
@5twelve 5twelve mentioned this pull request Aug 8, 2024
Open
This was referenced Aug 20, 2024
Closed
Closed
Closed
This was referenced Aug 28, 2024
Closed
Closed
Closed
Closed
This was referenced Sep 4, 2024
Closed
Closed
Closed
This was referenced Sep 13, 2024
Closed
Closed
Closed
This was referenced Sep 24, 2024
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes

Assignees

No one assigned

Labels

release:stage Stage a release candidate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.
< 35F9 /div>

2 participants

@maneesht @lahirumaramba
0