Initial commit - FR: realtime event listener for RTDB (#229) #245

johndelavega · 2019-05-25T00:42:59Z

Here's a pull request against dev

see cmd/listen/main.go for working simple test client app

To run the test app, edit main.go for credential json file location "edit 1." and db url "edit 2."
then from command line terminal, cd to cmd/listen
go run . init - creates snapshot user1/path1/key1:"init" for listener testing
go run . - starts listening
start a new command line terminal, cd to cmd/listen
go run . hey - this will trigger an event and should show up from other cmd line listener

Here's the gist of the code:

  iter, err := ref.Listen(ctx)
  
  defer iter.Stop()
  
  go func() {
    for {
      event, err := iter.Next()

      if err != nil {
        break
      }
    }
  }()

FR #229

hiranya911 · 2019-05-29T18:40:15Z

Thanks @johndelavega. The general shape of things look good. However the SSE sessions will die after an hour, when the underlying credential becomes invalid. You will need a way to reconnect when this happens. Also try to use the APIs in the json package as much as possible to parse SSE data.

johndelavega · 2019-05-30T16:48:10Z

Thanks for the feedback. Will work on the fix to reconnect. Will use json package for the SSE data parsing as that should make the code more resilient. Actually had plan to do that, so it was great seeing that feedback :)

johndelavega · 2019-06-17T08:00:53Z

Here's a fix for the timeout reconnection.

The code is tested and continued running for over 2 days.

The tested use case is similar to if we have a client-go SDK used for an IoT device or installed app using "authorized_user" JSON credential file,
like this: refresh_token.json

The JSON file is created from Google APIs Credential OAuth 2.0 Client IDs using Type: Other

This tool create-refresh-token can be used to create the JSON file.

This admin SDK can also be used as a client SDK, similar to Node.js SDK

johndelavega · 2019-06-21T03:21:17Z

Updated to use json package APIs for parsing SSE data.

This firebase-admin-go SDK can be used as firebase-client-go SDK using refresh_token "authorized_user" credential JSON file.

thatreguy · 2019-06-24T05:40:33Z

db/event_ref.go

+
+				var snapshotMap map[string]interface{}
+
+				err := json.Unmarshal([]byte(s[6:]), &snapshotMap)


Better to comment why you've used a constant here

Thanks. I've added comments from a recent commit.

@thatreguy I think you need to sign a CLA https://cla.developers.google.com/

googlebot · 2019-08-20T00:08:01Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

uses 2 simultaneous Listeners Unmarshal json-encoded event data

…irebase#229)

firebase#229) added SnapshotIterator.Done() updated test apps fixed variable scope for resp *http.Response

firebase#229) added comments in db/event_ref.go

googlebot · 2019-09-03T18:35:44Z

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

rebased branch jd-event-listener with upstream/master 'Bumped version to 3.9.0 ...' removed branch dev

smoya · 2019-10-06T18:55:14Z

Any update on this?

joseph-grabinger · 2021-09-06T13:56:11Z

Any updates on this ?
Got the Event Listeners working thanks to @johndelavega github repo.
Only issue I find is that the event is only triggered when I do manual changes from the firebase console.
However the event is NOT triggered when I change data from another app (flutter), nor is it triggered when I update data via the Firebase Database REST API.

iamkhalidbashir · 2023-09-26T12:27:41Z

I think they are not going to work on this, sad.

thatreguy reviewed Jun 24, 2019

View reviewed changes

johndelavega added 6 commits September 3, 2019 11:16

Initial commit - FR: realtime event listener for RTDB (firebase#229)

04d5088

added cmd/listen2/main.go

a267ffb

uses 2 simultaneous Listeners Unmarshal json-encoded event data

Code fix to reconnect when 'event: auth_revoked' occurs (firebase#229)

ad5b9f2

Much cleaner code using json package for handling SSE data payload (f…

2ddc43a

…irebase#229)

Fixed bug, SnapshotIterator.Stop() not working from reconnect code fix (

755934e

firebase#229) added SnapshotIterator.Done() updated test apps fixed variable scope for resp *http.Response

Updated test apps cmd/listen... to continue Listening when event fails (

7b1eda5

firebase#229) added comments in db/event_ref.go

johndelavega force-pushed the jd-event-listener branch from b8d59e4 to 7b1eda5 Compare September 3, 2019 18:35

Updated reconnect code for simplicity and stability (firebase#229)

8918988

rebased branch jd-event-listener with upstream/master 'Bumped version to 3.9.0 ...' removed branch dev

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial commit - FR: realtime event listener for RTDB (#229) #245

Initial commit - FR: realtime event listener for RTDB (#229) #245


		var snapshotMap map[string]interface{}

		err := json.Unmarshal([]byte(s[6:]), &snapshotMap)

Initial commit - FR: realtime event listener for RTDB (#229) #245

Are you sure you want to change the base?

Initial commit - FR: realtime event listener for RTDB (#229) #245

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment