8000 Updating the ListUsers() Implementation by hiranya911 · Pull Request #77 · firebase/firebase-admin-dotnet · GitHub
[go: up one dir, main page]
Skip to content

Updating the ListUsers() Implementation #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 19, 2019
Merged

Updating the ListUsers() Implementation #77

merged 9 commits into from
Jun 19, 2019

Conversation

hiranya911
Copy link
Contributor
@hiranya911 hiranya911 commented Jun 17, 2019 •
edited
Loading
  • Cleaned up the public API according to go/dotnet-user-mgt
  • Added tests to cover different ways of iterating through user accounts

Follow up to #58

@hiranya911 hiranya911 requested a review from bklimt June 17, 2019 22:35
bklimt
bklimt approved these changes Jun 19, 2019
View reviewed changes
Copy link
@bklimt bklimt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned hiranya911 and unassigned bklimt Jun 19, 2019
@hiranya911 hiranya911 merged commit 6061bec into master Jun 19, 2019
@hiranya911 hiranya911 deleted the hkj-list-cleanup branch June 19, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@bklimt bklimt bklimt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@hiranya911 hiranya911

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiranya911 @bklimt
0