[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #76 : Types findable when used as npm lib #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #76 : Types findable when used as npm lib #100

wants to merge 1 commit into from

Conversation

mpoisot
Copy link
@mpoisot mpoisot commented Oct 19, 2020

TypeScript types weren't getting recognized because package.json was missing the "types" property.

I also beefed up the types to get my own project to compile without warnings.

@jigarlodaya12
Copy link

Can This be merged ?

namoscato
namoscato approved these changes Feb 7, 2021
View reviewed changes
Copy link
@namoscato namoscato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for v3.x 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namoscato namoscato namoscato approved these changes

@ZeroCho ZeroCho ZeroCho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mpoisot @jigarlodaya12 @namoscato @ZeroCho