minor symfony#26107 [Console] Fix broken table generation (lcobucci)

chalasr · chalasr · commit 0733b17c894d · 2018-02-09T13:58:56.000+01:00
This PR was merged into the 4.1-dev branch. Discussion ---------- [Console] Fix broken table generation | Q | A | ------------- | --- | Branch? | master | Bug fix? | yes (in an optimisation which is only in `master`) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes (partially, at least they don't break badly anymore) | Fixed tickets | symfony#26081 | License | MIT In 2c9922e the code was optimised but the order of method calls was incorrect, leading to several errors in the test suite. Commits ------- 063ca2d Fix broken table generation
diff --git a/src/Symfony/Component/Console/Helper/Table.php b/src/Symfony/Component/Console/Helper/Table.php
@@ -565,7 +565,7 @@ private function getRowColumns(array $row): array
     /**
      * Calculates columns widths.
      */
-    private function calculateColumnsWidth(array $rows)
+    private function calculateColumnsWidth(iterable $rows)
     {
         for ($column = 0; $column < $this->numberOfColumns; ++$column) {
             $lengths = array();

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ private function getRowColumns(array $row): array`
`565`	`565`	`/**`
`566`	`566`	`* Calculates columns widths.`
`567`	`567`	`*/`
`568`		`- private function calculateColumnsWidth(array $rows)`
	`568`	`+ private function calculateColumnsWidth(iterable $rows)`
`569`	`569`	`{`
`570`	`570`	`for ($column = 0; $column < $this->numberOfColumns; ++$column) {`
`571`	`571`	`$lengths = array();`