Fix broken table generation

lcobucci · lcobucci · commit 063ca2d70846 · 2018-02-09T13:38:11.000+01:00
In 2c9922e the code was optimised but the order of method calls was incorrect, leading to several errors in the test suite. Not all the tests related to table generation got fixed, but at least the component is not broken anymore. Fixes symfony#26081
diff --git a/src/Symfony/Component/Console/Helper/Table.php b/src/Symfony/Component/Console/Helper/Table.php
@@ -565,7 +565,7 @@ private function getRowColumns(array $row): array
     /**
      * Calculates columns widths.
      */
-    private function calculateColumnsWidth(array $rows)
+    private function calculateColumnsWidth(iterable $rows)
     {
         for ($column = 0; $column < $this->numberOfColumns; ++$column) {
             $lengths = array();

Original file line number	Diff line number	Diff line change
`@@ -565,7 +565,7 @@ private function getRowColumns(array $row): array`
`565`	`565`	`/**`
`566`	`566`	`* Calculates columns widths.`
`567`	`567`	`*/`
`568`		`- private function calculateColumnsWidth(array $rows)`
	`568`	`+ private function calculateColumnsWidth(iterable $rows)`
`569`	`569`	`{`
`570`	`570`	`for ($column = 0; $column < $this->numberOfColumns; ++$column) {`
`571`	`571`	`$lengths = array();`