8000 Remove a slow parameter validation block by neboskreb · Pull Request #138 · feilipu/Arduino_FreeRTOS_Library · GitHub
[go: up one dir, main page]
Skip to content

Remove a slow parameter validation block #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Remove a slow parameter validation block #138

wants to merge 1 commit into from

Conversation

neboskreb
8000 Copy link
Contributor

This is alternative solution to #136

The validation block which contained a division operation is removed. In case of invalid parameters, the allocation properly fails at line 515 and the failure is detected on the next line:

            pxNewQueue = ( Queue_t * ) pvPortMalloc( sizeof( Queue_t ) + xQueueSizeInBytes );

            if( pxNewQueue != NULL )
            {
                ...
            }
            else
            {
                traceQUEUE_CREATE_FAILED( ucQueueType );
                mtCOVERAGE_TEST_MARKER();
            }

@neboskreb neboskreb mentioned this pull request Sep 29, 2024
Closed
@neboskreb
Copy link
Contributor Author

Decided to go with the other one, #137. Closing.

@neboskreb neboskreb closed this Sep 29, 2024
@neboskreb neboskreb deleted the bugfix/136-queue-remove-validation-block branch September 29, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@neboskreb
0