refactor!: Typescript#396
Closed
fratzinger wants to merge 5 commits intofeathersjs-ecosystem:masterfrom
Closed
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Complete refactor to
typescript. It's pretty straight forward. It's meant for feathers v4. So it can be released immediately.I only changed a few things:
eslint,c8instead ofnyc(follow other feathers packages)applyScopeand rename it toModelWithScope-> more declarative nameimport { hydrate } from 'feathers-sequelize'-> import from root and not subfolderconvertOperatorsfunctions since it can be useful for otherparamsToAdapteras suggested in feat: expose 'paramsToAdapter' method #390Tis thecrowgeneric for AdapterService andMis the type of theoptions.Model. This goes against the generics ofdovebut it is quite handy to have the right typings forservice.Model!Other than that there's nothing changed. The tests were left as is.
Considering these changes, I would release this as major, just to be sure. Even because the recommended way to import the hydrate/dehydrate hooks will stop working and changes from:
to
Closes #390 #395