fix(checkContext): type as array#636
Merged
daffl merged 4 commits intofeathersjs-ecosystem:masterfrom Jul 30, 2021
fratzinger:patch-1
Merged
fix(checkContext): type as array#636daffl merged 4 commits intofeathersjs-ecosystem:masterfrom fratzinger:patch-1
daffl merged 4 commits intofeathersjs-ecosystem:masterfrom
fratzinger:patch-1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
checkContextwas not able to handletypeas array, although it was defined inindex.d.ts.Solution:
transform
typeinto array (same asmethod) and check against type withArray.prototype.includes().Also added tests for this scenario.
No breaking change. No new feature. The typings already seem like this would work.