8000 express: use service.methods by bertho-zero · Pull Request #945 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

express: use service.methods#945

Merged
daffl merged 19 commits intofeathersjs:masterfrom
bertho-zero:express-handler
Apr 22, 2019
Merged

express: use service.methods#945
daffl merged 19 commits intofeathersjs:masterfrom
bertho-zero:express-handler

Conversation

@bertho-zero
Copy link
Contributor
@bertho-zero bertho-zero commented Aug 22, 2018 •
edited
Loading

@bertho-zero bertho-zero changed the title Apply feathersjs/express#29 PR express: use service.methods Aug 22, 2018
@bertho-zero bertho-zero requested a review from daffl August 22, 2018 18:23
@bertho-zero
Copy link
Contributor Author
bertho-zero commented Aug 23, 2018

@daffl I resolved the conflict with master.

@daffl
Copy link
Member
daffl commented Aug 23, 2018

Thank you. I think we might want to wait merging this (or making new changes in general) until the monorepo migration if finished and the latest version of everything has been published.

@daffl daffl mentioned this pull request Aug 23, 2018
Closed
@bertho-zero
Copy link
Contributor Author
bertho-zero commented Sep 4, 2018

@daffl I merged master and all the tests seem to pass.

@daffl
Copy link
Member
daffl commented Sep 17, 2018

So the difficulty with this one is that we can't force the dependent Feathers version unless it is a major (breaking) change. If someone has e.g. @feathersjs/feathers@3.1.x things will break (already seeing some issues around that, e.g. in #1000).

@bertho-zero
Copy link
Contributor Author
bertho-zero commented Sep 17, 2018

@feathersjs/express probably requires a major version.

@daffl
Copy link
Member
daffl commented Sep 17, 2018

I think so, too. Ok, I'll get this in with auth v3 (since authentication Express middleware will move here, too). It's going pretty well so it hopefully shouldn't be too long until a pre-release.

@Mairu
Copy link
Contributor
Mairu commented Apr 22, 2019

Please don't forget this for 4.0

@daffl daffl merged commit 3f0b1c3 into feathersjs:master Apr 22, 2019
@bertho-zero bertho-zero mentioned this pull request Jun 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daffl daffl Awaiting requested review from daffl

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bertho-zero @daffl @Mairu
0