Conversation
|
Thank you for the PR @TimNZ. Skipping even emitting should however already be possible by returning feathers.SKIP in the last hook you want to run. |
|
I knew about SKIP but didn't test well enough if it could achieve what I wanted. Have tested nested service calls and a simple hook and modifying context/params achieves desired flow. Though if any other 'finally' hooks ever get added in the future this will break them. |
|
If you decide not to have explicit event skipping support, My event logging module is separate from hooks handling, I like the modular micro approach you've taken and don't want to introduce dependencies. |
|
Haven't forgotten about this. Just figuring out if and how this will fit into the next release. |
|
@daffl Thanks. No rush. A context flag to skip events processing, decoupled from hook flow, still makes most sense to me. |
|
Allright, so what I'd like to allow for this release would be adding a hook |
|
Does the job. |
Refer to discussion here:
feathersjs-ecosystem/feathers-sequelize#188
Want granular control over event emitting after service methods.
You'll likely want to tidy up my test which is hacky.
I'm not knowledgeable on how you test for something NOT happening.