8000 Better logic for returning the hook object from method call by daffl · Pull Request #706 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Better logic for returning the hook object from method call#706

Merged
daffl merged 2 commits intomajorfrom
return-hook
Oct 25, 2017
Merged

Better logic for returning the hook object from method call#706
daffl merged 2 commits intomajorfrom
return-hook

Conversation

@daffl
Copy link
Member
@daffl daffl commented Oct 24, 2017

In some cases - specifically for the service providers - we want to allow to return the hook object instead of only the result from a method call. This used to be possible by setting params.__returnHook but it is too easy to blow params away in a hook chain.

This new way returns the hook object if the last parameter in a service call is true.

@daffl daffl merged commit 0ba570d into major Oct 25, 2017
@daffl daffl deleted the return-hook branch October 25, 2017 00:00
This was referenced Oct 25, 2017
Merged
Merged
daffl added a commit that referenced this pull request Oct 29, 2017
@daffl
Better logic for returning the hook object from method call (#706)
3fe0f4a 
Better logic for returning the hook object from method call
daffl added a commit that referenced this pull request Oct 29, 2017
@daffl
Better logic for returning the hook object from method call (#706)
145817c 
Better logic for returning the hook object from method call
daffl added a commit that referenced this pull request Oct 29, 2017
@daffl
Better logic for returning the hook object from method call (#706)
da060c9 
Better logic for returning the hook object from method call
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@daffl
0