Update release notes URL for change log#686
Closed
binury wants to merge 1 commit intofeathersjs:masterfrom
binury:patch-1
Closed
Update release notes URL for change log#686binury wants to merge 1 commit intofeathersjs:masterfrom binury:patch-1
binury wants to merge 1 commit intofeathersjs:masterfrom
binury:patch-1
Conversation
Merged
Member
|
Thank you @teddy-error! I added a complete generated changelog instead in #695 since it was actually completely missing. |
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
As discussed in #684, the current default for subject causes token verification to fail if sub is overriden. Removing subject from default options might be a breaking change as people might rely on it. Remove subject from verification options, so it's not checked. This is a safer way.
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
As discussed in #684, the current default for subject causes token verification to fail if sub is overriden. Removing subject from default options might be a breaking change as people might rely on it. Remove subject from verification options, so it's not checked. This is a safer way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #665