8000 Allow flag to return the hook object by daffl · Pull Request #607 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Allow flag to return the hook object#607

Merged
daffl merged 1 commit intomajorfrom
return-hooks
Jul 1, 2017
Merged

Allow flag to return the hook object#607
daffl merged 1 commit intomajorfrom
return-hooks

Conversation

@daffl
Copy link
Member
@daffl daffl commented Jun 29, 2017

This will be used by the updated providers (primarily to retrieve hook.dispatch which will contain the "safe" data to send to a client). Allows to do something like:

app.service('dummy').find({
  __returnHook: true
}).then(hook => {
  // hook is the actual hook object instead of just the result
});

@ekryski
Copy link
Contributor
ekryski commented Jun 29, 2017

Looks good @daffl do we have a test somewhere that actually makes sure the hook object is returned when the flag is set? The default is falsey I'm assuming.

@daffl
Copy link
Member Author
daffl commented Jun 29, 2017

It's at the bottom of the diff: https://github.com/feathersjs/feathers/pull/607/files#diff-3c6456101c2eef8b9a21f4595301eebeR157

@daffl daffl merged commit 9d8380a into major Jul 1, 2017
@daffl daffl deleted the return-hooks branch July 1, 2017 19:32
@daffl daffl mentioned this pull request Jul 6, 2017
Closed
daffl added a commit that referenced this pull request Jul 19, 2017
@daffl
Allow flag to return the hook object (#607)
5ffaa0f
daffl added a commit that referenced this pull request Aug 9, 2017
@daffl
Allow flag to return the hook object (#607)
5977786
daffl added a commit that referenced this pull request Oct 19, 2017
@daffl
Allow flag to return the hook object (#607)
be6ccb4
daffl added a commit that referenced 9C23 this pull request Oct 20, 2017
@daffl
Allow flag to return the hook object (#607)
cc0e5f7
daffl added a commit that referenced this pull request Oct 29, 2017
@daffl
Allow flag to return the hook object (#607)
c6e6727
daffl added a commit that referenced this pull request Oct 29, 2017
@daffl
Allow flag to return the hook object (#607)
74365ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daffl @ekryski
0