8000 Fix typings by cranesandcaff · Pull Request #587 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Fix typings#587

Merged
eddyystop merged 2 commits intofeathersjs:masterfrom
cranesandcaff:fix-typings
May 23, 2017
Merged

Fix typings#587
eddyystop merged 2 commits intofeathersjs:masterfrom
cranesandcaff:fix-typings

Conversation

@cranesandcaff
Copy link
Contributor
@cranesandcaff cranesandcaff commented May 22, 2017

Summary

The before, after and hooks were missing from the service causing an error in the ts compiler when doing

const service = app.service('name')
  .before(beforeHooks)
  .after(afterHooks)

(If you have not already please refer to the contributing guideline as described
here)

  • Tell us about the problem your pull request is solving.
  • Are there any open issues that are related to this?
  • Is this PR dependent on PRs in other repos?

If so, please mention them to keep the conversations linked together.

Other Information

If there's anything else that's important and relevant to your pull
request, mention that information here. This could include
benchmarks, or other information.

Your PR will be reviewed by a core team member and they will work with you to get your changes merged in a timely manner. If merged your PR will automatically be added to the changelog in the next release.

If your changes involve documentation updates please mention that and link the appropriate PR in feathers-docs.

Thanks for contributing to Feathers! ❤️

@eddyystop
Copy link
Contributor
eddyystop commented May 23, 2017

Thanks. We appreciate your PRs.

@eddyystop eddyystop merged commit dbc101a into feathersjs:master May 23, 2017
@daffl
Copy link
Member
daffl commented May 29, 2017

Thank you! Released as v2.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cranesandcaff @eddyystop @daffl
0