Conversation
|
This looks great! I was trying to do this last night but hit some issues with refactoring the tests. Thanks for doing this! In the long term though, does feathers want to move away from the configure method? |
|
Is the configure method such a bad thing (it's not doing the environment specific configuration anymore)? I was debating of renaming it but we need some nice way to load plugins I think. This: app.configure(feathers.rest()).use('/todos', todoService);Looks a lot nicer than var app = feathers();
feathers.rest.call(app);
// or
feathers.rest(app);
app.use('/todos', todoService); |
|
I was going with the |
|
To me in this case being explicit feels kind of clunky. I like fluid interfaces (guess I'm jQuery damaged ;) and Express already goes with it. The biggest problem is that if you do something like: var app = feathers().use('/todos', todoService);;
feathers.rest.call(app);
// or
feathers.rest(app);Things won't work as expected. It's easier to say "You need to configure providers and plugins first." vs. "You need to call the provider or plugin with your application before adding other Middleware or services.". |
|
That makes sense |
|
👍 |
* Refactoring for compatibility with Feathers v3 * Finalization of hook methods * Change getHooks back to previous version * Prepare for 1.0 prerelease * 1.0.0-pre.1 * Updating changelog * Update to new plugin infrastructure * Update .npmignore * Remove Node 4 from Travis * 1.0.0-pre.2 * Updating changelog * Update the client test suite (#55) * Update release script * 1.0.0-pre.3 * Updating changelog
* Refactoring for compatibility with Feathers v3 * Finalization of hook methods * Change getHooks back to previous version * Prepare for 1.0 prerelease * 1.0.0-pre.1 * Updating changelog * Update to new plugin infrastructure * Update .npmignore * Remove Node 4 from Travis * 1.0.0-pre.2 * Updating changelog * Update the client test suite (#55) * Update release script * 1.0.0-pre.3 * Updating changelog
…cs (#55) * chore(package): update semistandard to version 12.0.0 * Remove example and update Readme to point directly to the Feathers docs
* Bring back Cookie token extractor * Increase code coverage
* Bring back Cookie token extractor * Increase code coverage
Express 4.0.0 got released a week ago. This pull requests implements the changes necessary for Feathers to use it and removes the default configuration of the REST provider (#53) which makes things even easier.
Closes #53, closes #54.