8000 Fix pagination type definition. by asdacap · Pull Request #527 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Fix pagination type definition.#527

Merged
daffl merged 1 commit intofeathersjs:masterfrom
asdacap:fix-pagination-type
Mar 14, 2017
Merged

Fix pagination type definition.#527
daffl merged 1 commit intofeathersjs:masterfrom
asdacap:fix-pagination-type

Conversation

@asdacap
Copy link
Contributor
@asdacap asdacap commented Mar 8, 2017

As specified in #520,

I've seems to have found an issue. Shouldn't the pagination interface be like

interface Pagination <T> {
   total: Number,
   limit: Number,
   skip: Number,
   data: T[] // As in, with an array instead of a single object?
}

@daffl daffl merged commit 521376e into feathersjs:master Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@asdacap @daffl
0