Update feathers-commons to version 0.8.0 🚀#459
Merged
Conversation
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Fix variable name typo * Add Visual Studio Code to .gitignore * Fix socketio authentication Channel socket auth through the token service instead of calling app.authenticate manually. This also makes it so the client has to provide a strategy explicitly, and removes the strategy iteration from `passport/authenticate.js`. Also updates tests. * The login event isn’t getting emitted. I’ve added a couple of debugger statements here and have set up the tests so that the failing test is the only one running. For some reason the debuggers never get hit. I have yet to find the cause. * Remove debuggers and fix tests * Remove two lines of old code. * Remove old comments * Update comment * Better syntax for reading from request.body.
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
* Fix variable name typo * Add Visual Studio Code to .gitignore * Fix socketio authentication Channel socket auth through the token service instead of calling app.authenticate manually. This also makes it so the client has to provide a strategy explicitly, and removes the strategy iteration from `passport/authenticate.js`. Also updates tests. * The login event isn’t getting emitted. I’ve added a couple of debugger statements here and have set up the tests so that the failing test is the only one running. For some reason the debuggers never get hit. I have yet to find the cause. * Remove debuggers and fix tests * Remove two lines of old code. * Remove old comments * Update comment * Better syntax for reading from request.body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
feathers-commons just published its new version 0.8.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of feathers-commons.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 39 commits .
9fe10aa0.8.02554efaImplementing lodash utilities and helpers for selecting (#38)48ba47fAdding coverage to .npmignore, Slack notifications to Travis file and Slack badge to readme8755263Windows support2baedc8Adding .github to .npmignore959adb8Adding .github folder and templatese859824Merge pull request #37 from feathersjs/semistandard80a215ejshint —> semistandard6ab4e4fUpdating changelog078ba9b0.7.851ec96dMake getting the service in base test dynamic (#36)9346bddUpdating changelog65189a60.7.7eb478adAllow app in hookObject. Update base client tests to take a name and app. (#35)6f391b2Updating changelogThere are 39 commits in total. See the full diff.