8000 Create an app reference on service event hook object by kaiquewdev · Pull Request #406 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Create an app reference on service event hook object #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Sep 15, 2016
Merged

Create an app reference on service event hook object #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
abb0532
Create an app reference on hook object
Sep 13, 2016
b7182af
Test of hook.app included on the event scenario
Sep 13, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/mixins/event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ function upperCase(name) {
}

export default function(service) {
const app = this;
const isEmitter = typeof service.on === 'function' &&
typeof service.emit === 'function';
const emitter = service._rubberDuck = rubberduck.emitter(service);
Expand Down Expand Up @@ -47,6 +48,7 @@ export default function(service) {
const hook = hookObject(method, 'after', args);
const data = Array.isArray(results[1]) ? results[1] : [ results[1] ];

hook.app = app;
data.forEach(current => service.emit(event, current, hook));
} else {
service.emit('serviceError', results[0]);
Expand Down
25 changes: 25 additions & 0 deletions test/mixins/event.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,4 +209,29 @@ describe('Event mixin', () => {
instance.emit('created', { custom: 'event' });
});
});

it('sets hook.app', done => {
const FixtureService = Proto.extend({
update(id, data, params, cb) {
setTimeout(function () {
cb(null, {
id: id,
name: data.name
});
}, 20);
}
});

const instance = create.call(FixtureService);
const dummyApp = { isApp: true };

mixinEvent.call(dummyApp, instance);

instance.on('updated', function (data, hook) {
assert.deepEqual(hook.app, dummyApp);
done();
});

instance.update(12, { name: 'Updated tester' }, {}, function () {});
});
});
0