fix(knex): Adds Error Handler to knex _update and _patch function#3371
Merged
8000
daffl merged 1 commit intofeathersjs:dovefrom Jan 5, 2024
Merged
fix(knex): Adds Error Handler to knex _update and _patch function#3371daffl merged 1 commit intofeathersjs:dovefrom
daffl merged 1 commit intofeathersjs:dovefrom
Conversation
daffl
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Currently Knex errors for _patch and _update bubble up without formatting and thus might reveal a lot of information about the underlying DB that is inappropriate for the end user. This makes error handling more uniform across the library.
From code commits, I could not see a reason why error catching was not added.