fix(memory): Ensure correct pagination totals#3307
Merged
daffl merged 1 commit intofeathersjs:dovefrom Oct 11, 2023
Merged
Conversation
daffl
approved these changes
Oct 11, 2023
Member
|
Thank you for fixing that! Will go out shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the comments made at #2844.
When pagination is enabled, the total is now correct and essentially works as things used to. There are two changes from the original implementation.
1 - We check
hasQuerybefore running the matcher. This is something I mentioned in my first PR. It just means that for our most basic calls likeservice.find()that we don't match the whole array for no reason.2 - We now also add
this.idin_select(value, params, this.id)). This ensures that the record ID is always selected, and is more in line with how most of the the DB adapters work. We may or may not want this, but its something to note as you guys are moving this over to Wings.