fix(schema): HookContext is now typed in schema#3306
Merged
daffl merged 3 commits intofeathersjs:dovefrom Oct 11, 2023
Merged
Conversation
daffl
approved these changes
Oct 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the generators for
*.schemafiles to include a type forHookContext.Without typing
HookContext<Service>the revolvers experience type issues.Other Information
With this PR, the only place that the generator doesn't type
HookContextis in thelogErrorhook, which can easily be typed toanyAfter-which, we can remove the default for the
HookContextgeneric. https://github.com/feathersjs/feathers/blob/dove/packages/generators/src/app/templates/declarations.tpl.ts#L30I propose to replace the default
HookContext<S = any>toHookContext<S extends ServiceMethods>