8000 fix(authentication-oauth): Properly handle all oAuth errors by daffl · Pull Request #3284 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

fix(authentication-oauth): Properly handle all oAuth errors #3284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 1 commit into from
Sep 27, 2023
Merged

fix(authentication-oauth): Properly handle all oAuth errors #3284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/authentication-oauth/src/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export class OAuthError extends FeathersError {
constructor(
message: string,
data: any,
public location: string
public location?: string
) {
super(message, 'NotAuthenticated', 401, 'not-authenticated', data)
}
Expand Down Expand Up @@ -114,12 +114,17 @@ export class OAuthService {
query,
redirect
}

const payload = grant?.response || result?.session?.response || result?.state?.response || params.query
const authentication = {
strategy: name,
...payload
}

if (payload.error) {
throw new OAuthError(payload.error_description || payload.error, payload)
}

try {
debug(`Calling ${authService}.create authentication with strategy ${name}`)

Expand Down
0