fix(typebox): Allow default value in StringEnum#3281
Merged
daffl merged 1 commit intofeathersjs:dovefrom Oct 3, 2023
Merged
Conversation
daffl
approved these changes
Sep 26, 2023
daffl
requested changes
Sep 26, 2023
Member
There was a problem hiding this comment.
Thank you. I think that makes sense we just have to add it to the docs at https://github.com/feathersjs/feathers/blob/dove/docs/api/schema/typebox.md#stringenum as well.
daffl
approved these changes
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #3280
Other Information
This is a PR that expands
StringEnumto accept a default value. I would prefer to expand the type to allow for all of theTSchemaproperties. But I was not able to figure out the types for it.Would appreciate some assistance completing the types if possible