fix(generators): Fix configure channels when not real-time app#3271
Merged
daffl merged 2 commits intofeathersjs:dovefrom Sep 11, 2023
Merged
fix(generators): Fix configure channels when not real-time app#3271daffl merged 2 commits intofeathersjs:dovefrom
daffl merged 2 commits intofeathersjs:dovefrom
Conversation
704e22d to
bd10098
Compare
daffl
approved these changes
Sep 11, 2023
Member
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When I create a new project with feathers cli the app configure "channels" even if I answer the app is not a real-time app.
The presence of this line make an error when I run the project wich said "channels is undefined".
I see the import of "channels" is conditioned by the presence of "websockets" but not the "app.configure".