8000 fix(transport-commons): Handle invalid service paths on socket lookups by daffl · Pull Request #3241 · feathersjs/feathers · GitHub
[go: up one dir, main page]

Skip to content

fix(transport-commons): Handle invalid service paths on socket lookups#3241

Merged
daffl merged 2 commits intodovefrom
routing-failsafe
Jul 19, 2023
Merged

fix(transport-commons): Handle invalid service paths on socket lookups#3241
daffl merged 2 commits intodovefrom
routing-failsafe

Conversation

@daffl
Copy link
Member
@daffl daffl commented Jul 17, 2023

This is a fix for a security issue where the conversion of the following template string:

const message = `${{ toString: '' }}`

Triggers an error killing the NodeJS process. This error happens when e.g. sending a socket.emit('find', { toString: '' }) message.

@daffl daffl changed the title fix(transport-commons): P 9350 revent sockets from looking up paths with implicit toString fix(transport-commons): Prevent error from looking up invalid paths Jul 17, 2023
@daffl daffl changed the title fix(transport-commons): Prevent error from looking up invalid paths fix(transport-commons): Handle invalid service paths on socket lookups Jul 17, 2023
@daffl daffl merged commit c397ab3 into dove Jul 19, 2023
@daffl daffl deleted the routing-failsafe branch July 19, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

0