8000 fix(koa): Replace koa-bodyparser with koa-body by 8BallBomBom · Pull Request #3093 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

fix(koa): Replace koa-bodyparser with koa-body#3093

Merged
daffl merged 1 commit intofeathersjs:dovefrom
8BallBomBom:dove
Mar 8, 2023
Merged

fix(koa): Replace koa-bodyparser with koa-body#3093
daffl merged 1 commit intofeathersjs:dovefrom
8BallBomBom:dove

Conversation

@8BallBomBom
Copy link
Contributor
@8BallBomBom 8BallBomBom commented Mar 8, 2023

Been looking at possible ways to implement an upload service.

After looking over the current options it would appear either we use koa-body to allow handling of multipart/form-data or we roll the dice and find another package as koa-bodyparser doesn't support multipart/form-data.

There is also the option where each developer could import and use koa-body themselves.
But there is currently a type compatibility issue with the older koa-bodyparser package.
More info over here.

What i can say though is it seems koa-body functions as a more up to date feature full drop in replacement.
Might need some extra testing though.

@daffl daffl changed the title koa-body as a replacement for koa-bodyparser fix(koa): Replace koa-bodyparser with koa-body Mar 8, 2023
@daffl daffl merged commit 2456bf8 into feathersjs:dove Mar 8, 2023
@caiqueacct
Copy link
caiqueacct commented Oct 12, 2023

Is possible to create a sample how to upload a file using koa-body? I can see the file being saved on the OS but I don't know how to get the filename saved using the context. This is how I configured:

app.use(
  bodyParser({
    multipart: true,
    jsonLimit: '10mb',
    formidable: {
      uploadDir: bucketUpload.upload
    }
  })
)

Thanks

@8BallBomBom
Copy link
Contributor Author
8BallBomBom commented Oct 12, 2023 •
edited
Loading

The way i'm handling this currently is by using the koa before hook in a service, check this.
ctx.request.files will return an array of files you're uploading.

As for the right way to implement things, that is a good question, currently i'm rocking a janky implementation of @koa/router to make sure only set routes allow uploads... otherwise every route will accept an upload.
Not really sure about the best method of implementation as of yet.

@caiqueacct
Copy link
caiqueacct commented Oct 14, 2023

Thanks. That's what I ended up using too. This is the code that I'm using although I also don't know if it's the best implementation but it's working like charm.

async (ctx, next) => {
  const readableStream = await getObjectStorage(
    objectStorage,
    result.objectName
  );
  const res = ctx.res;
  ctx.response.attachment(result.originalFilename, { type: "inline" });

  await new Promise((resolve, reject) => {
    const writableStream = new WritableStream({
      write(chunk) {
        try {
          res.write(chunk);
        } catch (e) {
          console.error("Error writing ", e);
        }
      },
    });

    readableStream
      .pipeTo(writableStream)
      .then(() => {
        res.end();
        resolve("SUCCESS");
      })
      .catch((e) => {
        console.error("Erro", e);
        reject(e.message);
      });
  });
};

@8BallBomBom
Copy link
Contributor Author
8BallBomBom commented Oct 15, 2023

Thanks for sharing, if i find a better way to handle things then i'll probably contribute towards the docs 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daffl daffl daffl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@8BallBomBom @caiqueacct @daffl
0