8000 fix(core): Use Symbol.for to instantiate shared symbols by daffl · Pull Request #3087 · feathersjs/feathers · GitHub
[go: up one dir, main page]

Skip to content

fix(core): Use Symbol.for to instantiate shared symbols#3087

Merged
daffl merged 1 commit intodovefrom
symbol-for-3071
Mar 8, 2023
Merged

fix(core): Use Symbol.for to instantiate shared symbols#3087
daffl merged 1 commit intodovefrom
symbol-for-3071

Conversation

@daffl
Copy link
Member
@daffl daffl commented Mar 1, 2023

This pull request ensures that all Symbols are shared from the global symbol registry so that it is possible to use different package versions.

Closes #3071

Copy link
Member
@marshallswain marshallswain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Lea 9F48 rn more.

:shipit:

@daffl daffl merged commit 7f3fc21 into dove Mar 8, 2023
@daffl daffl deleted the symbol-for-3071 branch March 8, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

@feathersjs/express^5 has a reused Symbol() across pkgs, but not actually equal

2 participants

0