-
-
Notifications
You must be signed in to change notification settings - Fork 797
- < 8000 div data-view-component="true" class="BtnGroup d-flex"> Star 15.2k
{{ message }}
fix(schema): Ensure that resolveResult and resolveExternal are run as around hooks#3032
Merged
fix(schema): Ensure that resolveResult and resolveExternal are run as around hooks#3032
Conversation
✅ Deploy Preview for feathers-dove canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#3004 introduced a change in the hook order to fix a regression in compatibility with v4. However, this breaks some app generated with v5 pre releases where
resolveResultandresolveExternalwere registered asafterhooks. SinceresolveResultshould be used as anaroundhook anyway for proper virtual property support, they will now throw an error if they are used asafterhooks.