Merged
Conversation
cb0862b to
cfaa447
Compare
Member
|
These are great, thank you! I think the CustomMethods change makes sense, we'll just have to update the docs. I wonder if there is a better way in TypeScript to do that. We're having a similar problem making service method typings more flexible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicationtype parametersServiceTypestoServicesandAppSettingstoSettings. That's the change that does not solve anything and a breakish one (since when somebody augment a module they have to use same names). Can remove.TtoanyinServicetype (and its relatives), so that you can simply writeServiceinstead ofService<any>. There is some slight difference betweenService/Service<any>andService<any, any>- first one hasDasPartial<any>. If this change comes up somewhere, there is a way to add new type later to defaultDtoanyifTisany.authenticationpackage had a problem withlib/index.d.tswhere there was an import of@feathersjs/hookswhich is not a direct dependency of the package, fixed by tweaking exports.transport-commonsfix types forPublisher(wrong type forcontextarg) andApplication.channel(not supporting an argument of typestring | string[]).CustomMethodtype toCustomMethodsand allow to easily specifydataand return type or keep itanyas it currently is.enableLegacyHooks(so include custom and filter out unused ones).koaadd headers to params (not sure if should be cloned as query is, inexpressneither query nor headers are cloned).koaadd types for feathers props on koa context -feathersandhook.transport-commonsandexpressremovehooksdependency and use correct type for context - it isn't supposed to work with generic hook context, only with feathers one.