E538 docs(typescript): fix misleading parameter name by Gabrola · Pull Request #2106 · feathersjs/feathers · GitHub
[go: up one dir, main page]

Skip to content

docs(typescript): fix misleading parameter name#2106

Merged
daffl merged 1 commit intofeathersjs:crowfrom
Gabrola:fix-param-name
Nov 8, 2020
Merged

docs(typescript): fix misleading parameter name#2106
daffl merged 1 commit intofeathersjs:crowfrom
Gabrola:fix-param-name

Conversation

@Gabrola
Copy link
Contributor
@Gabrola Gabrola commented Oct 23, 2020

For IDEs with autocompletion, this argument name is slightly misleading. context makes more sense and is in line with the rest of the hooks documentation.

@Gabrola Gabrola changed the title docs(typescript): fix misleading param name docs(typescript): fix misleading parameter name Oct 23, 2020
@daffl daffl merged commit 2f91398 into feathersjs:crow Nov 8, 2020
@daffl
Copy link
Member
daffl commented Nov 8, 2020

Makes sense, thank you!

@Gabrola Gabrola deleted the fix-param-name branch November 8, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0