Fix data property definition in @feathersjs/errors#2018
Merged
daffl merged 1 commit intofeathersjs:crowfeathersjs/feathers:crowfrom Nov 22, 2020
tinovyatkin:patch-1
Merged
Fix data property definition in @feathersjs/errors#2018daffl merged 1 commit intofeathersjs:crowfrom tinovyatkin:patch-1
data property definition in @feathersjs/errors#2018daffl merged 1 commit intofeathersjs:crowfrom
tinovyatkin:patch-1
Conversation
`data` is described in TypeScript definitions as always defined property, while from [the actual implementation](https://github.com/feathersjs/feathers/blob/c838d8bc4b8a78cb90a2d299bfe4f7b6b8d8c2f8/packages/errors/lib/index.js#L8) it can be undefined. This PR fixes that definition to be according to actual code.
Member
|
Thank you! This has been updated already in the v5 (dove) branch but since it may still be a bit it makes sense to get it out for this version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
datais described in TypeScript definitions as always defined property, while from the actual implementation it can be undefined. As result direct assignment to anderror.data.boowere not catched by TypeScript.This PR fixes that definition to be according to actual code.