Conversation
|
Hi, I was about to publish a bug report but I see this correction seems to relate to issue I had, but I'm not convinced it'll solve it... I'll have to try (soon I promise). When calling authenticate (strategy 'jwt') As a workaround, I was hiding context.sequelize.include from auth hook and re-injecting it. here below the hook I used as a 'fix' and below how I implemented $inculde[] if this can help anyone. hooks/fix-authenticate-sequelize-include.ts // Use this hook to manipulate incoming or outgoing data.
// For more information on hooks see: http://docs.feathersjs.com/api/hooks.html
import { Hook, HookContext } from '@feathersjs/feathers';
import * as authentication from '@feathersjs/authentication';
import { AuthenticateHookSettings } from '@feathersjs/authentication/lib/hooks/authenticate';
const { authenticate } = authentication.hooks;
/*
When calling authenticate (strategy 'jwt')
and that context.params has a sequelize include
in my case a service (tags) including a model alias 'parents' of type belongsToMany(tags, through: tagsTags)
tags and tagsTags have in the model description (but wasn't included in the current call) a relations belongsTo(users, as: author)
then an error would emerge out of users service
error: 'invalid reference to FROM-clause entry for table "tags"'
error: error app.service('users').get()
here part of the SQL
FROM
"users" AS "users"
LEFT OUTER JOIN (
"tags_tags" AS "parents->tags_tags"
INNER JOIN "tags" AS "parents" ON "parents"."id" = "parents->tags_tags"."parentTagId"
) ON "users"."id" = "parents->tags_tags"."tagId"
AND "parents"."id" != "tags"."id"
LEFT OUTER JOIN "media" AS "parents->featuredImage" ON "parents"."featuredMediumId" = "parents->featuredImage"."id"
WHERE
("users"."id" = '1');
So on querying users it would try to link to the models included in the request to 'tags' service
As a workaround I 'proxied' the authenticate() hook with this one, it basically deletes context.params.sequelize.include
import authenticate from '../../hooks/fix-authenticate-sequelize-include';
that I then use as I would normally use authenticate('jwt')
*/
export default (originalSettings: string | AuthenticateHookSettings, ...originalStrategies: string[]): Hook => {
return async (context: HookContext) => {
if (context.params && context.params.sequelize && context.params.sequelize.include) {
const { sequelize } = context.params;
const { include } = sequelize;
let contextWithoutInclude = context;
delete contextWithoutInclude.params.sequelize.include;
let authContext = await authenticate(originalSettings, ...originalStrategies)(contextWithoutInclude);
authContext.params.sequelize.include = include;
return authContext;
} else {
return authenticate(originalSettings, ...originalStrategies)(context);
}
};
};hooks/sequelize-include-remote-models.ts import { Hook, HookContext } from '@feathersjs/feathers';
import { mergeDeep, castToBoolean } from '../shared/utils';
import logger from '../logger';
import { merge } from 'lodash';
// import { Sequelize, DataTypes, Op } from 'sequelize';
const hydrate = require('feathers-sequelize/hooks/hydrate');
// inspired by https://stackoverflow.com/questions/48602085/using-feathers-client-and-sequelize-many-to-many-relation
// TODO: find how to do this the right way ( app.hooks(appHooks) in app.ts isn't so happy about this )
type HookContextWithAssociations = HookContext & { associations: { include: any[] } };
export default (options = {}): any => {
return async function (this: any, context: HookContextWithAssociations) {
switch (context.type) {
case 'before':
if (context.params && context.params.query) {
if ('$include' in context.params.query) {
const { $include, ...query } = context.params.query;
context.associations = context.associations || {};
context.associations.include = context.associations.include || [];
// thanks https://jsperf.com/array-coerce
(Array.isArray($include) ? $include : [$include]).forEach((name: string) => {
if (name in context.service.Model.associations) {
context.associations.include.push({
association: context.service.Model.associations[name],
as: name,
});
} else {
logger.error(
`Requested association '${name}' of model '%s' doesn't exist. Available associations are: %O`,
context.service.Model.name,
context.service.Model.associations
);
}
});
// Update the query to not include `$include`
context.params.query = query;
context.params.sequelize = context.params.sequelize || {};
merge(context.params.sequelize, context.associations, { raw: false });
}
if ('$raw' in context.params.query) {
const { $raw, ...query } = context.params.query;
// Update the query to not include `$raw`
context.params.query = query;
context.params.sequelize = context.params.sequelize || {};
Object.assign(context.params.sequelize, { raw: castToBoolean($raw) });
}
}
break;
case 'after':
// I still don't understand why we have to do this... but they say so :-/
if (context.associations && context.params && context.params.sequelize && !context.params.sequelize.raw) {
hydrate(context.associations).call(this, context);
}
break;
}
// return Promise.resolve(context);
return context;
};
}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up for #2009