Merged
Conversation
daffl
added a commit
that referenced
this pull request
Sep 20, 2013
Allows registering services with slashes
daffl
added a commit
that referenced
this pull request
Aug 21, 2018
* adding some commments and debug statements * Make socket provider property configurable
daffl
pushed a commit
that referenced
this pull request
Aug 21, 2018
* chore(package): update nsp to version 2.3.2 * Remove nsp check
daffl
added a commit
that referenced
this pull request
Aug 22, 2018
* adding some commments and debug statements * Make socket provider property configurable
daffl
pushed a commit
that referenced
this pull request
Aug 22, 2018
* chore(package): update nsp to version 2.3.2 * Remove nsp check
daffl
pushed a commit
that referenced
this pull request
Aug 23, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 25, 2018
moving server to src and fixing importing of services.
daffl
add
10BC0
ed a commit
that referenced
this pull request
Aug 25, 2018
Update all dependencies 🌴
daffl
pushed a commit
that referenced
this pull request
Aug 28, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 28, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
Fixing issue where next is called twice when hitting an unauthenticated service via socket.io
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
daffl
pushed a commit
that referenced
this pull request
Aug 29, 2018
Fixing issue where next is called twice when hitting an unauthenticated service via socket.io
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now services can be registered and looked up with trailing and leading slashes so that it fits in better with the express conventions. Also added application tests and a changelog.