8000 Adding tests to make sure that dispatcher context is set properly. by daffl · Pull Request #172 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

Adding tests to make sure that dispatcher context is set properly. #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 1 commit into from
Nov 17, 2015
Merged

Adding tests to make sure that dispatcher context is set properly. #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions test/providers/primus.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,7 @@ describe('Primus provider', function () {
var oldCreated = service.created;

service.created = function(data, params, callback) {
assert.ok(service === this);
assert.deepEqual(params, socketParams);
verify.create(original, data);

Expand All @@ -276,6 +277,8 @@ describe('Primus provider', function () {
});

it('.updated', function (done) {
// TODO this is not testing the right thing
// but we will get better event filtering in v2 anyway
var original = {
name: 'updated event'
};
Expand All @@ -293,6 +296,7 @@ describe('Primus provider', function () {
var oldRemoved = service.removed;

service.removed = function(data, params, callback) {
assert.ok(service === this);
assert.deepEqual(params, socketParams);

if(data.id === 23) {
Expand Down
4 changes: 4 additions & 0 deletions test/providers/socketio.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,6 +452,7 @@ describe('SocketIO provider', function () {
var oldCreated = service.created;

service.created = function(data, params, callback) {
assert.ok(service === this);
assert.deepEqual(params, socketParams);
verify.create(original, data);

Expand All @@ -469,6 +470,8 @@ describe('SocketIO provider', function () {
});

it('.updated', function (done) {
// TODO this is not testing the right thing
// but we will get better event filtering in v2 anyway
var original = {
name: 'updated event'
};
Expand All @@ -486,6 +489,7 @@ describe('SocketIO provider', function () {
var oldRemoved = service.removed;

service.removed = function(data, params, callback) {
assert.ok(service === this);
assert.deepEqual(params, socketParams);

if(data.id === 23) {
Expand Down
0