8000 fix(core): Improve hook missing parameter message by adding the service name by daffl · Pull Request #1703 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

fix(core): Improve hook missing parameter message by adding the service name #1703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Nov 26, 2019
Merged

fix(core): Improve hook missing parameter message by adding the service name #1703

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5a279
fix: Improve hook missing parameter message by adding the service name
daffl Nov 26, 2019
2d6f6f9
Fix rest-client test
daffl Nov 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/feathers/lib/hooks/base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,15 @@ const assignArguments = context => {
};

const validate = context => {
const { service, method } = context;
const { service, method, path } = context;
const parameters = service.methods[method];

if (parameters.includes('id') && context.id === undefined) {
throw new Error(`An id must be provided to the '${method}' method`);
throw new Error(`An id must be provided to the '${path}.${method}' method`);
}

if (parameters.includes('data') && !_.isObjectOrArray(context.data)) {
throw new Error(`A data object must be provided to the '${method}' method`);
throw new Error(`A data object must be provided to the '${path}.${method}' method`);
}

return context;
Expand Down
6 changes: 3 additions & 3 deletions packages/feathers/test/hooks/hooks.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@ describe('hooks basics', () => {

return app.service('dummy').get();
}).catch(e => {
assert.strictEqual(e.message, `An id must be provided to the 'get' method`);
assert.strictEqual(e.message, `An id must be provided to the 'dummy.get' method`);
}).then(() =>
app.service('dummy').create()
).catch(e => {
assert.strictEqual(e.message, `A data object must be provided to the 'create' method`);
assert.strictEqual(e.message, `A data object must be provided to the 'dummy.create' method`);
});
});

Expand Down Expand Up @@ -201,7 +201,7 @@ describe('hooks basics', () => {
assert.strictEqual(context.service, app.service('dummy'));
assert.strictEqual(context.type, 'error');
assert.strictEqual(context.path, 'dummy');
assert.strictEqual(context.error.message, 'An id must be provided to the \'get\' method');
assert.strictEqual(context.error.message, 'An id must be provided to the \'dummy.get\' method');
});
});

Expand Down
8 changes: 4 additions & 4 deletions packages/rest-client/test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,19 +79,19 @@ describe('REST client tests', function () {
const service = app.service('todos');

return service.get().catch(error => {
assert.strictEqual(error.message, `An id must be provided to the 'get' method`);
assert.strictEqual(error.message, `An id must be provided to the 'todos.get' method`);

return service.remove();
}).catch(error => {
assert.strictEqual(error.message, `An id must be provided to the 'remove' method`);
assert.strictEqual(error.message, `An id must be provided to the 'todos.remove' method`);

return service.update();
}).catch(error => {
assert.strictEqual(error.message, `An id must be provided to the 'update' method`);
assert.strictEqual(error.message, `An id must be provided to the 'todos.update' method`);

return service.patch();
}).catch(error => {
assert.strictEqual(error.message, `An id must be provided to the 'patch' method`);
assert.strictEqual(error.message, `An id must be provided to the 'todos.patch' method`);
});
});
});
0