8000 fix: Improve authentication client default storage initialization by daffl · Pull Request #1613 · feathersjs/feathers · GitHub
[go: up one dir, main page]

Skip to content

fix: Improve authentication client default storage initialization#1613

Merged
daffl merged 2 commits intomasterfrom
default-storage
Oct 10, 2019
Merged

fix: Improve authentication client default storage initialization#1613
daffl merged 2 commits intomasterfrom
default-storage

Conversation

@daffl
Copy link
Member
@daffl daffl commented Oct 9, 2019

In some cases browsers (like Brave when all cookies are blocked) throw an error when accessing window.localStorage. This pull request improves the initialization to return a fallback memory storage on any localStorage initialization error.

Closes #1344

@daffl daffl merged commit d7f5107 into master Oct 10, 2019
@daffl daffl deleted the default-storage branch October 10, 2019 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document using localStorage shim in certain private browsers

1 participant

0