8000 fix: Typings for express request and response properties by vonagam · Pull Request #1609 · feathersjs/feathers · GitHub
[go: up one dir, main page]
Skip to content

fix: Typings for express request and response properties #1609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daffl merged 2 commits into from
Oct 10, 2019
Merged

fix: Typings for express request and response properties #1609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09acd45
fix: Typings for express request and response properties
vonagam Oct 8, 2019
95a1cf4
Merge branch 'master' into improve-express-typings
daffl Oct 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion packages/express/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Application as FeathersApplication } from '@feathersjs/feathers';
import { Application as FeathersApplication, Params as FeathersParams, HookContext } from '@feathersjs/feathers';
import express from 'express';

declare const feathersExpress: FeathersExpress;
Expand Down Expand Up @@ -36,3 +36,14 @@ interface FeathersExpress extends Express {
declare namespace feathersExpress {
type Application<T = any> = express.Express & FeathersApplication<T>;
}

declare module 'express-serve-static-core' {
interface Request {
feathers?: Partial<FeathersParams>;
}

interface Response {
data?: any;
hook?: HookContext;
}
}
0