8000 fix: check for undefined access token by keywordnew · Pull Request #1571 · feathersjs/feathers · GitHub
[go: up one dir, main page]

Skip to content

fix: check for undefined access token#1571

Merged
daffl merged 1 commit intofeathersjs:masterfrom
keywordnew:1568/fix-undefined-access-token
Sep 21, 2019
Merged

fix: check for undefined access token#1571
daffl merged 1 commit intofeathersjs:masterfrom
keywordnew:1568/fix-undefined-access-token

Conversation

@keywordnew
Copy link
Contributor

Summary

  • Tell us about the problem your pull request is solving.

This PR adds a check for if the access token is undefined.

  • Are there any open issues that are related to this?

Fixes #1568.

  • Is this PR dependent on PRs in other repos?

Nope, AFAIK.

Other Information

This fix does not yet have a test.

@daffl daffl merged commit 976369d into feathersjs:master Sep 21, 2019
@daffl
Copy link
Member
daffl commented Sep 21, 2019

Awesome! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feathers auth assumes an accessToken exists for socket (regression)

2 participants

0